Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Added setting to change GCode-visualizer file size threshold to ui #1145 #1308
What does this PR do and why is it necessary?
It adds the ability to change the file size threshold of the gcode visualizer in the ui settings.
How was it tested? How can it be tested by the reviewer?
I tested on my machine with multiple files and different settings. It can be tested with the virtual printer, adding some Gcode-Files with different file sizes and load them.
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
I use Opera, FireFox, Safari, Chrome, and a linux browser.
I assume the response might be "set it to 0 and you are no worse off?"
The way it's implemented right now uses the exact number given, 0 would mean 0 bytes and no file would load automatically. If wanted i can implement that 0 means unlimited.
Could it be that you forgot to add a file to the commit? Only looking at the diff right now, but it seems like
Also, I have to admit, I'm a bit unsure about the positioning of the value configuration. Looks a bit "misplaced" right within the feature checkbox army there, but I'm also a bit unsure what might be a better place... I wonder if it might make sense to extract the gcode visualizer settings (enable flag + those two settings) into their own tab under "Features" maybe?