Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for gcode arc commands (G2/G3) in IJ notation #1382

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
2 participants
@eyck
Copy link
Contributor

commented Jun 21, 2016

What does this PR do and why is it necessary?

The patch adds rendering support for G2/G3 codes in the GCode Viewer tab.

How was it tested? How can it be tested by the reviewer?

It has been tested by using transformed gcode files loaded into the frontend. These files were created using gcodeutils (https://github.com/zeograd/gcodeutils).

Any background context you want to provide?

I extended the gcodeutils to detect and translate cirle segments into arcs (I plan to integrate this as a plugin into OctoPrint). It bothered me that OctoPrint does not show these segments and does wrong time and filament calculations. So easiest was to extend the javascript to do so.

What are the relevant tickets if any?

No tickets.

Screenshots

Left bottom is a segmented curve while the top right ones are arcs:

gcodeutils-1 3-py2 py3-none-any

@foosel foosel merged commit 9b34b8c into foosel:devel Jul 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eyck eyck deleted the eyck:gcode_arc_rendering branch Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.