Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "last (estimated) print time" to "last real print time" #1522

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@I-am-me
Copy link
Contributor

commented Sep 29, 2016

What does this PR do and why is it necessary?

This solves #1048

How was it tested? How can it be tested by the reviewer?

Launch the web interface and see if it corresponds to http://i.imgur.com/26GM8XU.jpg

Any background context you want to provide?

This is just a pull request for a feature developed by @ntoff

What are the relevant tickets if any?

#1048

Further notes

To answer #1048 I changed L357 to "output += gettext("Last Print Time") + ": " + formatDuration(data["prints"]["last"]["printTime"]);" as proposed by @ntoff

Changed "Last (estimated) print time" to real time
To answer #1048 I changed L357 to "output += gettext("Last Print Time") + ": " + formatDuration(data["prints"]["last"]["printTime"]);" as proposed by @ntoff

@foosel foosel merged commit 369e43e into foosel:devel Oct 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@foosel

This comment has been minimized.

Copy link
Owner

commented Oct 4, 2016

Thanks! Needed a small correction but then worked great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.