Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes issues with pip arguments being used when they shouldn't and not being used when they should #1583
What does this PR do and why is it necessary?
Makes it so that installing, uninstalling, and updating plugins uses the appropriately provided pip arguments.
How was it tested? How can it be tested by the reviewer?
Testing was done by setting the pluginmanager's pip_args setting to various values, like
Any background context you want to provide?
Pip wont uninstall a package if it's provided with inapplicable arguments like
I felt like the softwareupdater plugin should use the pluginmanager's pip_args setting when it uses pip to update a plugin. Since those pip arguments are what was needed to install the plugin in the first place then they are also needed to install the newest version of that plugin.
What are the relevant tickets if any?
Screenshots (if appropriate)
I left in code to make these changes easily scalable to allow adding more arguments that can be blacklisted depending on if pip is installing or uninstalling a package. As of right now it just includes blacklisting the
Thank you for your contribution! Sadly it looks like there is something wrong with this PR from your branch
Please take a look at the section on PRs in the Contribution Guidelines and make sure that your PR follows them. Thank you!
PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your PR is read by humans too, I'm just not one of them.