Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include LSB above first use in init.d script #1654

Merged
merged 1 commit into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@tullo-x86
Copy link
Contributor

commented Dec 14, 2016

What does this PR do and why is it necessary?

Fixes a late inclusion of the LSB functions in Octoprint's init.d script so that the include is executed before the first call to "log_warning_msg"

How was it tested? How can it be tested by the reviewer?

Follow the repro steps described in Issue 1653.

Any background context you want to provide?

Not sure why the init.d script only barfs on the most recent BBB image; OctoPrint v1.3.0 worked fine on an old image it was running from 2 years ago (which I only updated because the GPG keys of the old APT repository expired).

What are the relevant tickets if any?

Issue 1653

@foosel foosel merged commit ce4e04c into foosel:devel Dec 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 14, 2016

Thanks for that. Weird that this didn't produce issues earlier. I also pushed the fix on the maintenance branch so this will go into 1.3.1

@tullo-x86 tullo-x86 deleted the tullo-x86:fix-lsb-include branch Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.