Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1780: Safari Webcam Fix. #1786

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@ghulands
Copy link

commented Feb 20, 2017

What does this PR do and why is it necessary?
Disables the disabling/enabling of the webcam if running in Safari as it doesn't disassociate the img src of the stream and thus multiples bandwidth unnecessarily.

How was it tested? How can it be tested by the reviewer?
In Safari.

Any background context you want to provide?

What are the relevant tickets if any?
#1780
Screenshots (if appropriate)

Further notes

Greg Hulands

@foosel foosel merged commit a439608 into foosel:devel Feb 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 21, 2017

Thank you so much for this 👍! That really made my day - it doesn't happen that often that a user reporting a problem sends in a PR to fix it themselves :D

I'll also backport this to the maintenance branch so that it makes it into the 1.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.