Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing period and space so works #1860

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@ParkerK
Copy link
Contributor

commented Apr 11, 2017

Just fixing documentation so it's accurate. Won't run as is, needs the . and space as shown in requirements.txt

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2017

Hi @ParkerK,

Thank you for your contribution! Sadly it looks like there is something wrong with this PR from your branch patch-1 to OctoPrint:master:

  • Your PR's target branch master is not among the whitelisted target branches: devel, maintenance. Please always create PRs against the devel branch. Important bug fixes will be backported to maintenance where necessary.

Please take a look at the section on PRs in the Contribution Guidelines and make sure that your PR follows them. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your PR is read by humans too, I'm just not one of them.

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 11, 2017

Thank you for spotting this. I've manually merged the PR on the maintenance branch (for reasons, see above).

Github doesn't properly detect that, so I've closed this PR manually - don't be alarmed by that, it has been merged.

@foosel foosel closed this Apr 11, 2017

@ParkerK ParkerK deleted the ParkerK:patch-1 branch Apr 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.