Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix dragndrop upload #1867
Feel free to delete all this help text, then describe
What does this PR do and why is it necessary?
Fixes #202 so that the drag and drop upload doesn't disappear when the mouse stops moving.
How was it tested? How can it be tested by the reviewer?
I was able to reproduce the original issue and also see that this solution solves the issue. The reviewer should test that this doesn't break drag and drop on platforms that were already working.
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Another easier solution is to simply change the timeout from 100 to 400 as described in the issue. it's a smaller fix but a little clunky in that the page becomes less responsive.
I might be overlooking something here, but with the changes I'm getting this behaviour in Chrome 57.0.2987.133 and Firefox 52.0.2 under Windows 10:
It appears that the drop is never detected properly and hence the overlay is not removed. It works fine when just moving the dragged file out of the window, but actually dropping it blocks the UI for good. I assume you didn't see that in your own tests and we have a case of different behaviour across operating systems here?
Thanks, that looks better :) I'll squash this and cherry pick it to the