Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Clear upload data when Aborting cura profile upload modal. #1894
This fixes #1893 .
Also, only bind click to the "Confirm" button once instead of binding and unbinding it for each file. Binding it just once seems cleaner.
What does this PR do and why is it necessary?
Clear the upload data before loading the cura profile modal dialog so that the dialog contents are consistent with the upload data.
How was it tested? How can it be tested by the reviewer?
Follow procedure in the bug.
Any background context you want to provide?
In the bug.
What are the relevant tickets if any?
I've cherry picked this as f5fad51 to
Since Github currently doesn't pick up cherry picks properly, I'll now close this manually since it's merged. It won't be marked as merged though, please don't be alarmed by that.
As a side note, I updated the PR guidelines a while ago, PRs for bug fixes may now also be done against