Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation if disconnecting while printing #2466

Merged
merged 1 commit into from Mar 7, 2018

Conversation

@ntoff
Copy link
Contributor

ntoff commented Mar 7, 2018

What does this PR do and why is it necessary?

Add a confirmation dialog if a user attempts to disconnect from the printer while a print
is in progress

How was it tested? How can it be tested by the reviewer?

  • Connect to a printer
  • Start a print
  • Attempt to disconnect from the printer's serial connection
  • Additionally, pause the print and attempt to disconnect
  • Observe in both cases a dialog box should appear, asking a user if they wish to disconnect while a print is in progess.

Any background context you want to provide?

Fulfilling a feature request. Discussions were had about adding the ability to disable this confirmation, however I believe disconnecting while a print is in progress should be such a rare occurrence that the ability to bypass the confirmation is unnecessary.

What are the relevant tickets if any?

#2287

Screenshots (if appropriate)

image

Further notes

Fullfills a feature request:
#2287

Add a confirmation dialog if a user attempts to disconnect while a print
is in progress
@foosel foosel merged commit 125673b into foosel:maintenance Mar 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.