Fixed error in GCode viewer where multiple filaments available (e.g. … #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using Prusa MMU2), but only using a filament that isn't the first one e.g. filament 4
|
Well spotted, thanks for the fix! 👍 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed/merged. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
When multiple filaments are available (e.g. using a Prusa MMU2), but you are printing with say filament 4 only, the GCode Viewer throws errors as it loops over all filaments set on the layer - the unused ones are undefined and an exception gets generated). This causes the layer height slider to not get updated correctly.
How was it tested? How can it be tested by the reviewer?
Tested on with Prusa MK3 with MMU2.
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
N/A
Further notes
Fix is just to add check if filament is not undefined before using it