Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log tab added to download and remove logs #361

Merged
merged 2 commits into from Feb 24, 2014

Conversation

Projects
None yet
2 participants
@Salandora
Copy link
Collaborator

commented Jan 27, 2014

Added API support for log files.
Added a tab to easly manage log files.

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 15, 2014

Sorry for the late reply to that...

I like the idea, I'm just not so sure regarding the position (as in, another tab). Something like log files should probably only interest people who are also allowed to enter the settings, the regular user would probably not be interested in them (I'm open for arguments there though!). So I'd rather see this somewhere in the settings dialog. Opinions? :)

@Salandora

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 15, 2014

Well you're right it might be misplaced, I'll move it to the settings and check if it makes it nicer :)
Could take a while, working on the filemanager branch for folder support.

@Salandora

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2014

Log tab is now in Settings

@foosel foosel merged commit cf25d3d into foosel:devel Feb 24, 2014

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 24, 2014

Sorry that this took so long, will take a bit more time yet to work through the backlog of pull requests, you were quite the busy bee and I was out of commission thanks to back issues. In any case, big thanks! :)

I made some adjustments to the pull request, added API documentation, restricted access to admins, did some cosmetical things, stuff like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.