Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing branch field in DEFAULT dict #634

Merged
merged 1 commit into from Nov 4, 2014

Conversation

Projects
None yet
2 participants
@Wallacoloo
Copy link
Contributor

commented Nov 3, 2014

Should fix an error raised on line 951 (SHORT_VERSION_PY % DEFAULT) during Octoprint setup when there's no version info. More info here: https://groups.google.com/forum/#!topic/deltabot/8udyUsJ1c9M

Fix missing branch field in DEFAULT dict
Should fix an error raised on line 951 (SHORT_VERSION_PY % DEFAULT) during Octoprint setup when there's no version info. More info here: https://groups.google.com/forum/#!topic/deltabot/8udyUsJ1c9M
@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 3, 2014

I usually don't accept pull requests made against master (see here), but I'll make an exception here. Will modify it slightly though (branch "unknown", not "")

@Wallacoloo

This comment has been minimized.

Copy link
Contributor Author

commented Nov 4, 2014

My bad. Do note that if you default branch to "unknown" instead of "", it will cause slightly different behavior on line 806 ( if version_branch: ... ). This may or may not be desireable, so just beware.

@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 4, 2014

Good point, thanks for the heads up.

@foosel foosel merged commit 87234bd into foosel:master Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.