Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for Invalid cross-device link on Linux when /tmp is on another fs #717

Merged
merged 1 commit into from Jan 16, 2015

Conversation

Projects
None yet
3 participants
@Renha
Copy link
Contributor

commented Jan 13, 2015

Hello. There are fix for #710 and #716

When octoprint going to move a file from one directory to another on linux, if directories is located on different filesystems, os.rename wouldn't work, raising error "OSError: [Errno 18] Invalid cross-device link". In that pull request it is fixed with changing os.rename into shutil.move

Another effect of changing: shutil.move is high-level operation, which uses os.rename if it is acceptable, so maybe win32-specific code isn't needed with shutil (investigations still needed though).

@dattas

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2015

This appears to completely fix issue #710 for me.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 15, 2015

Just FYI, that's also the fix I had in mind, I just have to make sure that
there are no locations left which I didn't come around to yesterday, hence
no merge yet. Plus I wanted to experiment with win32 behaviour, looks like
that ugly workaround is still necessary though, since it's against win's
reluctance to overwrite existing files which still causes trouble here.
On 14 Jan 2015 22:48, "Dattas Moonchaser" notifications@github.com wrote:

This appears to completely fix issue #710
#710 for me.


Reply to this email directly or view it on GitHub
#717 (comment).

foosel added a commit that referenced this pull request Jan 16, 2015

Merge pull request #717 from Renha/devel
Bugfix for Invalid cross-device link on Linux when /tmp is on another fs

@foosel foosel merged commit 19df1ae into foosel:devel Jan 16, 2015

foosel added a commit that referenced this pull request Jan 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.