Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: Settings modal did not display properly on iPad and other browsers ... #823
Conversation
…rs under 1200px wide
foosel
added a commit
that referenced
this pull request
Apr 13, 2015
This comment has been minimized.
This comment has been minimized.
|
I solved it a bit differently and made the settings dialog more responsive in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
webmonger commentedMar 21, 2015
...under 1200px wide
The float in the modal over lay on browsers that are under 1200px wide cause the content that was supposed to be on the right hand side to flow below it.
I've changed the width of the menu and right content to use percentages, this might not be desired but it was the only way I could think to fix it. I'm far from a CSS expert so there might be a better way.