Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSettingsShown/Hidden call only on parent dialog shown/hidden #879

Merged
merged 1 commit into from May 5, 2015

Conversation

Projects
None yet
2 participants
@markwal
Copy link
Collaborator

commented Apr 30, 2015

jQuery bubbles all children show/hide events up to the parent so the
event gets called whenever a settings pane is chosen by the user.
Intent of the viewmodel callback was just on first show and final
dismiss.

onSettingsShown/Hidden call only on parent dialog shown/hidden
jQuery bubbles all children show/hide events up to the parent so the
event gets called whenever a settings pane is chosen by the user.
Intent of the viewmodel callback was just on first show and final
dismiss.

foosel added a commit that referenced this pull request May 5, 2015

Merge pull request #879 from markwal/onSettingsShown
onSettingsShown/Hidden call only on parent dialog shown/hidden

@foosel foosel merged commit 3e5298f into foosel:devel May 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@markwal markwal deleted the markwal:onSettingsShown branch May 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.