Change repo_unavailable path to absolute #962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative paths are problematic with bundling since the css location will be different based on whether bundled or unbundled. Unfortunately, absolute path is sensitive to plugin name changes and plugin asset url changes.
|
Oh yeah. That's configurable. Oops. |
foosel
added a commit
that referenced
this pull request
Jul 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative paths are problematic with bundling since the css location will be different based on whether bundled or unbundled. Unfortunately, absolute path is sensitive to plugin name changes and plugin asset url changes, but better than being sensitive to a runtime change.