Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChange repo_unavailable path to absolute #962
Closed
Conversation
Relative paths are problematic with bundling since the css location will be different based on whether bundled or unbundled. Unfortunately, absolute path is sensitive to plugin name changes and plugin asset url changes.
This comment has been minimized.
This comment has been minimized.
foosel
commented on 4530d45
Jul 8, 2015
|
That would have it break if the prefix URL is a different one. I have to get webassets to rewrite that path instead. I thought I'd taken care of that, but of course, what I did was only to rewrite less imports, not the other URLs too. |
This comment has been minimized.
This comment has been minimized.
|
Oh yeah. That's configurable. Oops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markwal commentedJul 7, 2015
Relative paths are problematic with bundling since the css location will be different based on whether bundled or unbundled. Unfortunately, absolute path is sensitive to plugin name changes and plugin asset url changes, but better than being sensitive to a runtime change.