Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change repo_unavailable path to absolute #962

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@markwal
Copy link
Collaborator

commented Jul 7, 2015

Relative paths are problematic with bundling since the css location will be different based on whether bundled or unbundled. Unfortunately, absolute path is sensitive to plugin name changes and plugin asset url changes, but better than being sensitive to a runtime change.

Change repo_unavailable path to absolute
Relative paths are problematic with bundling since the css location will
be different based on whether bundled or unbundled. Unfortunately,
absolute path is sensitive to plugin name changes and plugin asset url
changes.
@foosel

This comment has been minimized.

Copy link

commented on 4530d45 Jul 8, 2015

That would have it break if the prefix URL is a different one. I have to get webassets to rewrite that path instead. I thought I'd taken care of that, but of course, what I did was only to rewrite less imports, not the other URLs too.

@markwal

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2015

Oh yeah. That's configurable. Oops.

@markwal markwal closed this Jul 8, 2015

@markwal markwal deleted the markwal:repounavailimg branch Jul 8, 2015

foosel added a commit that referenced this pull request Jul 8, 2015

foosel added a commit that referenced this pull request Jul 8, 2015

Rewrite urls in packed css and less files
See also #962
(cherry picked from commit 7ea2ee2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.