Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base: Add validator, account and transaction URLs #427

Closed
kwunyeung opened this issue Oct 4, 2021 · 4 comments · Fixed by #445
Closed

Base: Add validator, account and transaction URLs #427

kwunyeung opened this issue Oct 4, 2021 · 4 comments · Fixed by #445

Comments

@kwunyeung
Copy link
Member

kwunyeung commented Oct 4, 2021

Update the /validators/{operate_address} url to /validator/{operate_address}.

Update the /accounts/{address} url to /account/{address}.

Update the /transactions/{tx_hash} url to /transaction/{tx_hash}.

This make the urls more sensible as the pages are referring to a single entry. This also align with the legacy BD which other services, e.g. Keplr, is pointing to.

@kwunyeung kwunyeung added base size/S type/enhancement New feature or request labels Oct 4, 2021
@kwunyeung kwunyeung changed the title Update account and transaction URLs Update validator, account and transaction URLs Oct 4, 2021
@ryuash
Copy link
Contributor

ryuash commented Oct 5, 2021

This breaks restful practice and does not make sense as there are multiple validators and not a single entity.

image

Another example would be mintscan

Legacy BD is not following restful practices but BD 2.0 is.

This issue would not be an enhancement but a step backwards

@ryuash
Copy link
Contributor

ryuash commented Oct 5, 2021

@yayay927 Instead of updating we will be adding these archived urls.

Goal:
Have both /validators/<validator_address> and /validator/<validator_address>

@ryuash ryuash changed the title Update validator, account and transaction URLs Base: Add validator, account and transaction URLs Oct 5, 2021
@yayay927
Copy link
Contributor

yayay927 commented Oct 5, 2021

@ryuash okay

@ryuash
Copy link
Contributor

ryuash commented Oct 5, 2021

update: we might be able to redirect instead https://nextjs.org/docs/api-reference/next.config.js/redirects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants