This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Upgrading to ReactNative 0.43.1 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: cwdick Differential Revision: D4537115 fbshipit-source-id: 61ee03d3e700bbee8b1cdb02bbf31a8491ca7891
Reviewed By: cwdick Differential Revision: D4543321 fbshipit-source-id: f7d5823b0d340f8ca17b3dd6caf4e158fa918bcf
Summary: Makes it easy to render separators between sections, as opposed to between items. Reviewed By: yungsters Differential Revision: D4555707 fbshipit-source-id: 34572ab4b2c5b47db640543149fe2551c34ccf7b
Reviewed By: javache Differential Revision: D4553755 fbshipit-source-id: 867685c67c53d4a659029f012e386a7be420d0ec
Summary: The way React DevTools integration was set up in RN was not entirely supported by the React team, and we had to disable it in c3b25c9 so that we can move forward with enabling Fiber support in React Native. Here, I am moving the DevTools client setup from RN repo to [React DevTools repo](https://github.com/facebook/react-devtools/blob/master/packages/react-devtools-core/README.md#requirereact-devtools-coreconnecttodevtoolsoptions) so that we can keep it in sync with the rest of React DevTools. This is also a part of a larger effort to consolidate DevTools code (facebook/react-devtools#489). It allows us to remove the double injection of the hook, an lets us replace the `eval` hack with a regular dependency. The implementation [lives here now](https://github.com/facebook/react-devtools/blob/master/packages/react-devtools-core/src/backend.js). This change re-enables Nuclide Inspector with React Native Stack reconciler and prepares it for compatibi Closes facebook#12316 Reviewed By: zertosh Differential Revision: D4545322 Pulled By: gaearon fbshipit-source-id: ab949916c1a92c6b41cd41e7e1edf9697a71de2e
Summary: Even so I know there are some opinions against ```margin: 0 auto``` it's still part of the spec: https://www.w3.org/TR/css-flexbox-1/#auto-margins and pretty usefull if you have to position via ```justify-content```. This PR adds an implementation for that. It adds an additonal ```YGUnitAuto``` and margins got ```YGNodeStyleSetMarginAuto``` functions as well. Closes facebook/yoga#357 Reviewed By: astreet Differential Revision: D4501142 Pulled By: emilsjolander fbshipit-source-id: 86519f8632496f46e78a7c9dbc5b21e212e3e0c7
Summary: ...to reflect the modern world we live in with dynamic DPI platforms :) Closes facebook/yoga#375 Reviewed By: dshahidehpour Differential Revision: D4528518 Pulled By: emilsjolander fbshipit-source-id: e422bd4ae148e02c598a7b484a6adfa8c0e1e0c9
Summary: Add simple `getRegistry()` so that add can do some custom handling of the registered components, if appropriate. Reviewed By: shergin Differential Revision: D4550600 fbshipit-source-id: 367c66b9fddfe4cc81cbc32a7a6043215e0df666
Reviewed By: dshahidehpour Differential Revision: D4555904 fbshipit-source-id: 8f0a2a9a38af42334188bc1cc5e0f6dded8592ae
Reviewed By: amnn Differential Revision: D4559594 fbshipit-source-id: 14dc9ec20e62a3568056d111aed2f263bcf6ac7e
Summary: **Test plan** 1. Add fonts using `react-native link` and a `"rnpm"` config in package.json 2. Manually delete one or more fonts from Xcode's Resources folder using Remove References option 3. Run `react-native link` again With the patch in this PR, the plist will not accidentally get populated with duplicate entries. Closes facebook#12048 Differential Revision: D4560432 fbshipit-source-id: aba3733acfd5373f8d654406b06b8338b137bc07
Reviewed By: yungsters Differential Revision: D4557672 fbshipit-source-id: a265231dbc992a84449e5ae051530f63f7b8efd4
Reviewed By: zjj010104 Differential Revision: D4540231 fbshipit-source-id: 87347ec95483e4414da0ac58399aa343d342e7d5
Summary: This test is failing there, so let's disable it for now. Reviewed By: shergin Differential Revision: D4562533 fbshipit-source-id: bf7e871bc227f870d4b7c228b41e65e725f54255
Summary: Syncs the latest changes from the React GitHub repo and takes a dependency on React 16 alpha. I had to hide the type checker stuff behind `__DEV__` because they now throw in production. Also disabled flow for findNodeHandle for now since we have some further clean up to do. Reviewed By: spicyj Differential Revision: D4526535 fbshipit-source-id: af5d282e75afbb293560b62fc72657461c24bdd1
Summary: This method was defined in the .m file already, so we can just expose it to the header for other usages. Reviewed By: mmmulani, shergin Differential Revision: D4557942 fbshipit-source-id: a1be8af8e31b88a152cabfab6d4cf82316088572
Reviewed By: shergin Differential Revision: D4557948 fbshipit-source-id: 439e486d1ef9e29c81cabf608943f7c62098a14b
Reviewed By: mhorowitz Differential Revision: D4550996 fbshipit-source-id: bcae58fa83c41aa649466e8cc2ebc2e4aa1b7436
Reviewed By: shergin Differential Revision: D4559391 fbshipit-source-id: 44cb4900f93f2ac60dae3a461ed5344e1af08f3b
Reviewed By: dcaspi Differential Revision: D4551097 fbshipit-source-id: 33b43b2691d4e595d3c09c9a5b101ce458c4d6d7
Reviewed By: mhorowitz Differential Revision: D4551110 fbshipit-source-id: e593c1ef0dea27e95a387bcde6250aeb22d2e9cc
Reviewed By: amnn Differential Revision: D4558676 fbshipit-source-id: 1ec2b1a5a8df08074ba06162ab2585f02d1d214b
Summary: Remove no longer valid limitiation hints, according to percentag, auto margins and flex values. Closes facebook/yoga#402 Reviewed By: astreet Differential Revision: D4564709 Pulled By: emilsjolander fbshipit-source-id: ef7f37921644b4d315c7a84552861713061b33e1
Reviewed By: bestander, lacker Differential Revision: D4562337 fbshipit-source-id: 2ca24344435b650a9c740eba9b196e70015b5cdb
Summary: In order for `CxxModule` modules to be able to do things like emit events, we need to expose the bridge instance. To allow classes derived from `CxxModule` in other projects to include `<cxxreact/Instance.h> I also needed to convert all the header includes to non-relative ones. Reviewed By: javache Differential Revision: D4564145 fbshipit-source-id: a5bc28dd9b40e2b141af9e867105c56083fbdcdc
Reviewed By: javache Differential Revision: D4553803 fbshipit-source-id: 4be36668f8e93123db3e1e78745b89ec4248b944
Reviewed By: sriramramani Differential Revision: D4540427 fbshipit-source-id: 8bdc0d2318371315b95300cdc6ca10bd0dbb55dd
Summary: I couldn't resist to do this 😄 facebook#394 This adds ```flex-wrap: wrap-reverse``` I think we hit a edge case here: https://stackoverflow.com/questions/33891709/when-flexbox-items-wrap-in-column-mode-container-does-not-grow-its-width as is differs here from chrome, but I think that yoga is here more correct. So I haven't added this test yet as this would fail against chrome, as chrome outputs a width of 30 for root, whereas yoga gets a width of 60 here, which I think is correct. Strangely the output of ```flex-wrap:wrap``` is in jsfiddle also only with a (visual) width of 30 on chrome, while the tests gets generated with 60. ```html <div id="wrap_reverse_column" style="height: 100px; flex-wrap: wrap-reverse"> <div style="height: 30px; width: 30px;"></div> <div style="height: 30px; width: 30px;"></div> <div style="height: 30px; width: 30px;"></div> <div style="height: 30px; width: 30px;"></div> </div> ``` Looking forward what you think here emilsjolander Closes facebook/yoga#398 Reviewed By: astreet Differential Revision: D4564711 Pulled By: emilsjolander fbshipit-source-id: 33dc055abd8444b2aa7796ef90bd7ec99e961bb8
Reviewed By: zertosh, bestander Differential Revision: D4559304 fbshipit-source-id: 797555447f789d09150b0d4b95b27fcac0aacdc6
Summary: allow-large-files By using async/await the code is (1) less nested, (2) more compact and (3) more robust (no exceptions running away, and much less risks of forgetting to call the callback/resolve, or mistakenly calling it twice). I now tend to think we could switch to it for all the callsites that are not in a perf-critical path. I switched from 'request' to 'node-fetch' because 'request' has an annoying callback with 2 arguments. So it's simpler to use an interface that's (1) already returning a Promise and (2) that is becoming standard. This changeset was a way for me to start experiment with introducing async/await in packager codebase, and it looks pretty good so far. Reviewed By: cpojer Differential Revision: D4559167 fbshipit-source-id: 89a328c5766c2ba890e9d0e67a81a38dac6cfc73
Summary: Starting in RN 0.43, lets start recommending people to move off of NavExperimental, now that a better navigation option is available, and hybrid options on the horizon. Reviewed By: hramos Differential Revision: D4634268 fbshipit-source-id: 2f37cc62f9729ae123d85f609a88f84516a5ae92
Summary: NavigationExperimental is deprecated, so we should avoid documenting it with examples Reviewed By: lacker, hramos Differential Revision: D4634484 fbshipit-source-id: 6c8b114d2a7b49c75ec548025384fa6ed75cb2d2
Summary: Xcode 8 is required as of 453e70d Closes facebook#12810 Differential Revision: D4677067 Pulled By: hramos fbshipit-source-id: 6de932fe8a79b13f0bb13aba10baf2d1960f8a4f
Summary: For unknown reasons, setting elevation: Number.MAX_VALUE causes remote debugging to hang on iOS (some sort of overflow maybe). Setting it to Number.MAX_SAFE_INTEGER fixes the iOS issue, but since elevation is an android-only style property we might as well remove it altogether for iOS. See: facebook#12223 Closes facebook#12744 Differential Revision: D4684524 Pulled By: mkonicek fbshipit-source-id: 7fb4f6da1c5c0cb437beff0e75122523e7233b72
…calls dispatched Summary: This is breaking because it affects the contract for onBatchComplete, but modules really shouldn't (and probably aren't) depending on it being called without any actual native module method calls having happened. Reviewed By: javache Differential Revision: D4715656 fbshipit-source-id: 53ddd4a26c9949de86f5111d214b3e5002ca2e94
Reviewed By: yungsters Differential Revision: D4648383 fbshipit-source-id: fdb8e2deaa06b2d2f9002cee2c0b827dbd7a5570
Reviewed By: yungsters Differential Revision: D4697335 fbshipit-source-id: 742b7a1729ba7a08fe3d9707bcf6c51026779739
Summary: Forgot to update these after rename... Reviewed By: yungsters Differential Revision: D4723788 fbshipit-source-id: 8cf7e8de57a23d9ee0a424aa9c0d62ab1cfbbb12
Reviewed By: blairvanderhoof Differential Revision: D4723575 fbshipit-source-id: a120eef4079a808bd3dead08df93989e1db3d96a
Reviewed By: hramos Differential Revision: D4663872 fbshipit-source-id: cb2bd2a2d588a9419da7517304d0612e259151e3
Reviewed By: angelahess Differential Revision: D4662787 fbshipit-source-id: 6e28f8cacd08601254e70f30ab98ee27bd08cc5a
Summary: Android instrumentation tests keep failing due to `java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for JS thread`. An [earlier job](https://circleci.com/gh/facebook/react-native/17064) based off commit [c31a65](facebook@c31a656) finished successfully, yet [this job](https://circleci.com/gh/facebook/react-native/17070), triggered by the very [next commit](facebook@e82c2fb), failed Android instrumentation tests even though that commit touches no Android code. You can see from the [Circle history](https://circleci.com/gh/facebook/react-native/tree/master) that this test has been consistently failing for the same time out reason. I am disabling Android instrumentation tests as they are not providing any useful signal a this point in time. Debug and fix instrumentation tests, and re-enable them. Closes facebook#13239 Differential Revision: D4810775 Pulled By: hramos fbshipit-source-id: 8866f9208ec3b5ac5f0ed2f6c2cf58c5b5825830
Summary: These modules don't exist in React anymore so this causes new apps to redscreen because the packager cannot resolve those modules. **Test plan** Tested that this and removing NavigationExperimental (it also uses removed React exports) causes UIExplorer to work again. Closes facebook#13095 Differential Revision: D4757762 Pulled By: ericvicenti fbshipit-source-id: bb246d4c6b15f5d3c71e31f133a468aea220f308
Summary: Closes facebook#13111 Differential Revision: D4761971 Pulled By: davidaurelio fbshipit-source-id: 668dcc58e8e1b075ee760233abc6904beede9218
Reviewed By: sebmarkbage Differential Revision: D4748563 fbshipit-source-id: 137c8bd637549c455bff3be61143e8e438c6a886
# Conflicts: # React.podspec # React/React.xcodeproj/project.pbxproj # ReactAndroid/gradle.properties # ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleConstantsTest.java # ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleTest.java # package.json # packager/react-packager/src/Activity/__mocks__/chalk.js # packager/src/Logger/__mocks__/chalk.js # scripts/bump-oss-version.js # website/core/WebPlayer.js
|
@wmathurin Same as vanilla |
wmathurin
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.