Skip to content

fix: better output for mystery component #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: better output for mystery component #1018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/resolve/connectionResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
*/

import { PollingClient, StatusResult, Connection, Logger } from '@salesforce/core';
import { PollingClient, StatusResult, Connection, Logger, SfError, Messages } from '@salesforce/core';
import { Duration, ensureArray } from '@salesforce/kit';
import { retry, NotRetryableError, RetryError } from 'ts-retry-promise';
import { ensurePlainObject, ensureString, isPlainObject } from '@salesforce/ts-types';
Expand All @@ -14,6 +14,10 @@ import { standardValueSet } from '../registry/standardvalueset';
import { FileProperties, StdValueSetRecord, ListMetadataQuery } from '../client/types';
import { extName } from '../utils';
import { MetadataComponent } from './types';

Messages.importMessagesDirectory(__dirname);
const messages = Messages.loadMessages('@salesforce/source-deploy-retrieve', 'sdr');

export interface ResolveConnectionResult {
components: MetadataComponent[];
apiVersion: string;
Expand Down Expand Up @@ -49,14 +53,22 @@ export class ConnectionResolver {
let componentType: MetadataType;
if (typeof component.type === 'string' && component.type.length) {
componentType = this.registry.getTypeByName(component.type);
} else {
} else if (typeof component.fileName === 'string' && component.fileName.length) {
// fix { type: { "$": { "xsi:nil": "true" } } }
componentType = ensurePlainObject(
this.registry.getTypeBySuffix(extName(component.fileName)),
`No type found for ${component.fileName} when matching by suffix. Check the file extension.`
);
component.type = componentType.name;
} else {
// has no type and has no filename!
throw new SfError(
messages.getMessage('error_could_not_infer_type', [component.fullName]),
'TypeInferenceError',
[messages.getMessage('suggest_type_more_suggestions')]
);
}

Aggregator.push(component);
componentTypes.add(componentType);
const folderContentType = componentType.folderContentType;
Expand Down