From d79e448900fb74ec6d8464cd6b66d4486f31e9eb Mon Sep 17 00:00:00 2001 From: mshanemc Date: Tue, 18 Jan 2022 08:56:23 -0600 Subject: [PATCH 1/5] fix: return ignored non-metadata --- src/resolve/metadataResolver.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/resolve/metadataResolver.ts b/src/resolve/metadataResolver.ts index a3423fbace..f0a357276f 100644 --- a/src/resolve/metadataResolver.ts +++ b/src/resolve/metadataResolver.ts @@ -108,6 +108,11 @@ export class MetadataResolver { return components; } } + } else { + // the file is not metadata, but could be in the forceignore, in which case we'd want to report it + if (this.forceIgnore.denies(fsPath)) { + this.forceIgnoredPaths.add(fsPath); + } } } From 764fdbd76cf38db3847d47efa2606f5db761ed8e Mon Sep 17 00:00:00 2001 From: mshanemc Date: Tue, 18 Jan 2022 09:03:42 -0600 Subject: [PATCH 2/5] test: wrong import in test --- test/convert/transformers/metadataTransformerFactory.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/convert/transformers/metadataTransformerFactory.test.ts b/test/convert/transformers/metadataTransformerFactory.test.ts index 93d531af0f..55fdcbb88b 100644 --- a/test/convert/transformers/metadataTransformerFactory.test.ts +++ b/test/convert/transformers/metadataTransformerFactory.test.ts @@ -18,7 +18,7 @@ import { DECOMPOSED_COMPONENT } from '../../mock/type-constants/customObjectCons import { COMPONENT_1 } from '../../mock/type-constants/customlabelsConstant'; import { RegistryError } from '../../../src/errors'; import { nls } from '../../../src/i18n'; -import { registry } from '../../../scripts/update-registry/update2'; +import { registry } from '../../../src/registry'; const registryAccess = new RegistryAccess(); From 55a30102de708721ebc7868195c285c50aef27aa Mon Sep 17 00:00:00 2001 From: mshanemc Date: Tue, 18 Jan 2022 09:13:57 -0600 Subject: [PATCH 3/5] test: work around frozen registry --- test/convert/transformers/metadataTransformerFactory.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/convert/transformers/metadataTransformerFactory.test.ts b/test/convert/transformers/metadataTransformerFactory.test.ts index 55fdcbb88b..2aee056ac7 100644 --- a/test/convert/transformers/metadataTransformerFactory.test.ts +++ b/test/convert/transformers/metadataTransformerFactory.test.ts @@ -61,7 +61,10 @@ describe('MetadataTransformerFactory', () => { it('should throw an error for a missing transformer mapping', () => { const component = new SourceComponent({ name: 'Test', - type: registry.types.apexclass, + type: { + ...registry.types.apexclass, + strategies: { adapter: 'matchingContentFile', transformer: 'MissingStrategies' }, + }, xml: 'Test.xml', }); component.type.strategies.transformer = 'MissingStrategies'; From 43d5b9b50bf868b39c41e1991cc38ae1fb985387 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Tue, 18 Jan 2022 09:15:32 -0600 Subject: [PATCH 4/5] chore: adding types for SDR --- METADATA_SUPPORT.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/METADATA_SUPPORT.md b/METADATA_SUPPORT.md index 0cbd248db8..c11e5dbcdc 100644 --- a/METADATA_SUPPORT.md +++ b/METADATA_SUPPORT.md @@ -4,7 +4,7 @@ This list compares metadata types found in Salesforce v54 with the [metadata reg This repository is used by both the Salesforce CLIs and Salesforce's VSCode Extensions. -Currently, there are 420/464 supported metadata types. +Currently, there are 420/465 supported metadata types. For status on any existing gaps, please search or file an issue in the [Salesforce CLI issues only repo](https://github.com/forcedotcom/cli/issues). To contribute a new metadata type, please see the [Contributing Metadata Types to the Registry](./contributing/metadata.md) @@ -139,6 +139,7 @@ To contribute a new metadata type, please see the [Contributing Metadata Types t |Dashboard|✅|| |DashboardFolder|✅|| |DataCategoryGroup|✅|| +|DataConnectorIngestApi|❌|Not supported, but support could be added| |DataConnectorS3|✅|| |DataDotComSettings|✅|| |DataMapping|✅|| @@ -482,7 +483,12 @@ v55 introduces the following new types. Here's their current level of support |Metadata Type|Support|Notes| |:---|:---|:---| +|DataActionDefinition|❌|Not supported, but support could be added| |Experience|undefined|undefined| +|ExternalDataTranField|❌|Not supported, but support could be added| +|ExternalDataTranObject|❌|Not supported, but support could be added| +|RegisteredExternalService|❌|Not supported, but support could be added| +|StreamingAppDataConnector|❌|Not supported, but support could be added| ## Additional Types From 0d3026da4937caddaff6b1dcf6611de11c56e4c0 Mon Sep 17 00:00:00 2001 From: mshanemc Date: Wed, 19 Jan 2022 09:48:23 -0600 Subject: [PATCH 5/5] ci: don't use windows latest --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4bbead1f27..1a16ca4616 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -30,7 +30,7 @@ jobs: node_version: description: version of node to run tests against type: string - default: 'latest' + default: 'lts' os: description: operating system to run tests on type: enum @@ -157,7 +157,7 @@ workflows: - maintenance exclude: - os: windows - node_version: lts + node_version: latest - os: windows node_version: maintenance - external-nut: