Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project directory restructure (Build Flavors) #87

Closed
3 of 4 tasks
fdocr opened this issue Jun 19, 2020 · 1 comment
Closed
3 of 4 tasks

Project directory restructure (Build Flavors) #87

fdocr opened this issue Jun 19, 2020 · 1 comment
Labels
feature request feature requests; wait for 'approved' label to begin work optimization refactor status: approved issues where contributions are welcome

Comments

@fdocr
Copy link
Contributor

fdocr commented Jun 19, 2020

Is your feature request related to a problem? Please describe.

We've recently felt that the current project directory structure is a little too complex for our needs.

Our currently modular project directory (data, buildSrc, baseui, app) feels more appropriate for native apps that benefit from Activity/Fragment/ect reuse. In our case we deal with very few moving parts.

Describe the solution you'd like

We're open at the moment to contributions where we can simplify our project directory structure. The ideal result is a minimal directory structure where we can easily work on enhancing our main Main Activity & browsing experience with the custom WebViewClient.

The suggested changes that we're looking to see in a PR for this are the following:

  • Simplified directory structure
  • Consider removal of databinding
  • Keep integrations we already have in the project (i.e. refreshVersions)
  • Configuration of Build Flavors: To reduce contributors friction to spin up their local development and start working on the app we can provide a google-services.json dummy file for debug/development (read more about this)

Additional context

PR's for this issue are very welcome. If you have a question or want to suggest alternatives feel free to leave a comment in this issue. We are open to hearing ideas on how to make our directory a minimal version of what we currently have.

@fdocr fdocr added status: approved issues where contributions are welcome refactor optimization feature request feature requests; wait for 'approved' label to begin work labels Jun 19, 2020
@fdocr fdocr added the hacktoberfest recommended issues for hacktoberfest participants label Sep 30, 2020
@fdocr fdocr changed the title Simplify project directory structure Project directory restructure (Build Flavors) Sep 30, 2020
@fdocr fdocr removed the hacktoberfest recommended issues for hacktoberfest participants label Nov 8, 2020
@rt4914
Copy link
Contributor

rt4914 commented Sep 20, 2022

Closing this as it is not required now.

@rt4914 rt4914 closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature requests; wait for 'approved' label to begin work optimization refactor status: approved issues where contributions are welcome
Projects
None yet
Development

No branches or pull requests

2 participants