Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link highlighted #97

Closed
schmelto opened this issue Sep 7, 2020 · 1 comment
Closed

Link highlighted #97

schmelto opened this issue Sep 7, 2020 · 1 comment
Labels
optimization status: approved issues where contributions are welcome

Comments

@schmelto
Copy link

schmelto commented Sep 7, 2020

Describe the bug
Through scrolling the news feed done links change there color without really clicking on them.

To Reproduce

  1. Go to news feed
  2. Scroll down
  3. Taping on link through scrolling (not enter)

Expected behavior
Heighlght after kicking and entering the link.

Smartphone:

  • Device: Huawei P10
  • OS: Android
  • Version: 9
@fdocr fdocr added hacktoberfest recommended issues for hacktoberfest participants optimization labels Sep 30, 2020
@fdocr
Copy link
Contributor

fdocr commented Sep 30, 2020

This is a visual enhancement that could definitely be added to the App. However, this is the general way links behave in the browser as well, so the solution lives somewhere between the web app and here.

If we can find some CSS patch to apply to make sure the links don't get highlighted when scrolling it would be a great addition. A posssible way to do this is:

var node = document.createElement('style');
node.type = 'text/css';
node.innerHTML = '<CSS_PATCH>';
document.head.appendChild(node);

The JS suggestion above could be manually evaluated (injecting the CSS patch) in the WebView to avoid highlighting links during the normal scroll with the finger. At a first glance this mainly affects links in the feed that are anchor tags nested under a div with the crayons-story__title class.

@fdocr fdocr added status: approved issues where contributions are welcome and removed hacktoberfest recommended issues for hacktoberfest participants labels Nov 8, 2020
@schmelto schmelto closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization status: approved issues where contributions are welcome
Projects
None yet
Development

No branches or pull requests

2 participants