Skip to content

Fix Android lint warnings #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2019
Merged

Fix Android lint warnings #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d716d65
Add content description to splash ImageView
roberto-o-r May 27, 2019
6944140
Remove unused resource
roberto-o-r May 27, 2019
ab3fbb8
Remove redundant namespace
roberto-o-r May 27, 2019
8130301
Enable full backup and suppress android version warning
roberto-o-r May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@

<application
android:allowBackup="true"
android:fullBackupContent="true"
android:usesCleartextTraffic="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/AppTheme"
tools:ignore="GoogleAppIndexingWarning"
tools:ignore="GoogleAppIndexingWarning,UnusedAttribute"
>
<activity
android:name=".view.main.view.MainActivity"
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/res/layout/activity_main.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>

<layout>
<layout xmlns:android="http://schemas.android.com/apk/res/android">

<data>

</data>

<androidx.constraintlayout.widget.ConstraintLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
Expand All @@ -18,7 +17,8 @@
android:layout_width="match_parent"
android:visibility="visible"
android:background="@color/colorPrimary"
android:src="@drawable/ic_launcher_foreground" />
android:src="@drawable/ic_launcher_foreground"
android:contentDescription="@string/splash_description"/>

<WebView
android:id="@+id/web_view"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
<resources>
<string name="app_name">DEV Community</string>
<string name="splash_description">Splash</string>
</resources>
1 change: 0 additions & 1 deletion data/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
<resources>
<string name="app_name">basedata</string>
</resources>