Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiftlint config and linter corrections with minor improvements. #105

Merged
merged 1 commit into from Dec 1, 2018

Conversation

StriderHND
Copy link
Contributor

In this PR I have updated the .swiftlint.yml file to look at the correct new folder (From DEV -> To DEV-Simple) also added to the .swiftlint.yml to ignore the Carthage directory, also for the ones using Xcode the reporter has been change from JSON to Xcode. to able to see the warnings.

With swiftLint working again a did a formatting with the linter recommendations, with this preliminary setup with can discuss the use of custom rules for styling in the development of the app.

Also I did a change for some memory leaks with strong self references in closures.

Any questions I'm glad to respond.

  • Erick

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you sign the CLA and then we're all good to go.

@StriderHND
Copy link
Contributor Author

StriderHND commented Nov 30, 2018

@benhalpern I've already signed the CLA but is not refreshing I guess.

@benhalpern
Copy link
Contributor

benhalpern commented Dec 1, 2018

Okay I'm not entirely sure what the issue is. It could be an email misalignment, but the confirmation that you signed is good for the record.

@benhalpern benhalpern merged commit 3e49a6c into forem:master Dec 1, 2018
@benhalpern benhalpern mentioned this pull request Dec 1, 2018
@StriderHND StriderHND deleted the fixes/swiftlint-errors branch December 1, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants