Feature 115 loading spinner #118
Conversation
There was a problem hiding this comment.
When I visit an outside link, the spinner is not visible (which would be not so bad), but then when I close that popup, the spinner persists on the original view.
Change needed: either the spinner needs to work properly in this use case or not be triggered in this case. 🙂
|
@benhalpern ok let me check that right now |
|
Here's a gif of the issue |
|
Hello Ben I've tried to look at the gif but looks like has a expiration date. now is a 404. |
|
@StriderHND Hey sorry, this should work: https://imgur.com/a/7XrpVdq |
Perfect!, let me check this right away. |
…dInBrowserView to use instead navigation segue functions.
|
@benhalpern I've corrected the issues and made some more refectory on the function that was presenting the external links, I made a change to use segues instead of making a direct instance from the storyboard that way we preserve hierarchy on the views. |
DEV-Simple/ViewController.swift
Outdated
| @@ -187,7 +193,7 @@ class ViewController: UIViewController, WKNavigationDelegate { | |||
| } else if isAuthLink(url) { | |||
| return .allow | |||
| } else if url.host != "dev.to" && navigationType.rawValue == 0 { | |||
| loadInBrowserView(url: url) | |||
| performSegue(withIdentifier: "showExternalPage", sender: url) | |||
There was a problem hiding this comment.
Could you pull out this hard coded string to a global variable? Same with line 305
There was a problem hiding this comment.
If we are going to start to add global variables we should add a struct for this.
This PR resolves the Feature Request in #115 adding a Loading Spinner for the first time a app opens or when the app opens from a push notification