Navigation color border #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Origin Master to origin Fork
benhalpern
requested changes
Jan 15, 2019
There was a problem hiding this comment.
This looks pretty close.
The only issue is that there is a color inconsistency (which is subtle)
If you zoom in you can see the difference in colors.
The background of this toolbar area should always be the tan color of RGB 254, 249, 243 (#FEF9F3 hex)
Currently the toolbar is (the default?) light grey, which causes the difference.
Looks like it is also this light grey when it is on its own as well:
The changing of the border is spot on and this all looks pretty close though!
|
Hello @benhalpern I've made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation border color problems fix as described in #122