Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Add padding to video duration (#1812)
* Add proper padding in video_duration_in_minutes

* Add proper padding in video_duration_in_minutes

* Remove ffmpeg from travis for now
  • Loading branch information
benhalpern committed Feb 16, 2019
1 parent 4465f9a commit 5d1370c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
6 changes: 3 additions & 3 deletions app/models/article.rb
Expand Up @@ -137,9 +137,8 @@ class Article < ApplicationRecord
per_environment: true,
enqueue: :trigger_delayed_index do
attributes :title, :path, :class_name, :comments_count, :reading_time,
:tag_list, :positive_reactions_count, :id, :hotness_score, :score,
:readable_publish_date, :flare_tag, :user_id, :organization_id,
:cloudinary_video_url, :video_duration_in_minutes
:tag_list, :positive_reactions_count, :id, :hotness_score, :score, :readable_publish_date,
:flare_tag, :user_id, :organization_id, :cloudinary_video_url, :video_duration_in_minutes
attribute :published_at_int do
published_at.to_i
end
Expand Down Expand Up @@ -395,6 +394,7 @@ def cloudinary_video_url
def video_duration_in_minutes
minutes = (video_duration_in_seconds.to_i / 60) % 60
seconds = video_duration_in_seconds.to_i % 60
seconds = "0#{seconds}" if seconds.to_s.size == 1
"#{minutes}:#{seconds}"
end

Expand Down
10 changes: 10 additions & 0 deletions spec/models/article_spec.rb
Expand Up @@ -226,6 +226,16 @@ def build_and_validate_article(*args)
article.save
expect(article).to be_valid
end

it "has padded video_duration_in_minutes" do
article.video_duration_in_seconds = 1141
expect(article.video_duration_in_minutes).to eq("19:01")
end

it "has correctly non-padded seconds in video_duration_in_minutes" do
article.video_duration_in_seconds = 1161
expect(article.video_duration_in_minutes).to eq("19:21")
end
end

describe "queries" do
Expand Down

0 comments on commit 5d1370c

Please sign in to comment.