Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing un-used email prop #11109

Closed
Rafi993 opened this issue Oct 27, 2020 · 1 comment · Fixed by #11108
Closed

Removing un-used email prop #11109

Rafi993 opened this issue Oct 27, 2020 · 1 comment · Fixed by #11108
Labels
bug always open for contribution type: optimization code and performance optimizations

Comments

@Rafi993
Copy link
Contributor

Rafi993 commented Oct 27, 2020

Describe the bug

Email displayed in app/javascript/chat/ChatChannelSettings/ModFaqSection.jsx is now replaced with link to /contact page but it was still taking in email prop which it does not use,

To Reproduce

  1. Go to the file app/javascript/chat/ChatChannelSettings/ModFaqSection.jsx
  2. You can see un-used email prop

Expected behavior

Remove un-used props

@github-actions
Copy link
Contributor

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@rhymes rhymes added area: connect bug always open for contribution type: optimization code and performance optimizations labels Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution type: optimization code and performance optimizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants