Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create liquid tag for medium.com articles #118

Closed
SamWSoftware opened this issue Dec 9, 2017 · 13 comments
Closed

Create liquid tag for medium.com articles #118

SamWSoftware opened this issue Dec 9, 2017 · 13 comments
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.

Comments

@SamWSoftware
Copy link

feature - liquid tag for medium.com articles

Have a liquid tag that woks something like
{% medium https://medium.com/article %}
To produce something similar to the link tag for dev.to articles

@Zhao-Andy
Copy link
Contributor

Hey Sam, thanks for the feedback. We'll put it in our backlog for now.

@jessleenyc jessleenyc added good first issue good first issues for anyone new to programming and new to the project. external contributors welcome contribution is welcome! labels Aug 21, 2018
@jessleenyc
Copy link
Contributor

hey @SamWSoftware! we're open source now, so if this is an issue you feel like working on please go for it here's some more info on liquid tags: https://docs.dev.to/liquid-tags/

@jacobherrington
Copy link
Contributor

Sounds like a good idea, I'm working on this!

@msarit
Copy link
Contributor

msarit commented Sep 20, 2018

@jacobherrington Hi there! whats's the status of this issue? 😄

@jacobherrington
Copy link
Contributor

@msarit still going, but got a bit distracted. If you're looking to knock it out, go ahead!

@msarit
Copy link
Contributor

msarit commented Sep 20, 2018

@jacobherrington I'll try my hand at it and update you before creating a PR, so we don't duplicate efforts 👍

@theoutlander
Copy link
Contributor

Issues that have been claimed should be assigned so it's easier to discover issues that need help.

@edisonywh
Copy link
Contributor

Hey guys, since the last reply was about two months ago I decided to pick it up, hope its okay. Check it out here #1161 and happy to take any feedback!

@stale
Copy link

stale bot commented Feb 18, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Feb 18, 2019
@maestromac
Copy link
Member

not stale

@stale stale bot removed the stale label Feb 18, 2019
@jessleenyc jessleenyc added the area: publishing experience issues related to an authors experience publishing. Tags, series, etc. label Mar 26, 2019
benhalpern pushed a commit that referenced this issue Apr 17, 2019
* Add ability to embed Medium URL as liquid tag

- Added new liquid tag - "{% medium https://medium.com}"
- Added a scraper - `MediumArticleRetrievalService` which crawls the
given Medium URL for informations needed for the liquid tag

* Add Medium logo in rendered liquid tag
coreyja added a commit to coreyja/dev.to that referenced this issue Apr 20, 2019
* master: (83 commits)
  Update gitdocs (forem#2500)
  Condense 'ask me anything' to 'ama' (forem#2428) [ci skip]
  Add user_signed_in? to cache key for styles (forem#2498)
  Added troubleshooting for byebug without readline issue (forem#2481)
  Fix some frontend linting issues (forem#2495) [ci skip]
  Fix <br/> in footer. (forem#2491)
  Remove extra param and add message for prefill (forem#2487)
  Make Cards Change Dynamically and add Reader/Follower Charts (forem#2488)
  Temporarily comment out random (forem#2486)
  Add nav buttons to pwa desktop (forem#2484)
  Feature/filtered charts (forem#2482)
  Add caching for historical data (forem#2476)
  There are installation sections for other OSes now. (forem#2480)
  Add inbox guidelines to users (forem#2473)
  Release Open Inbox (forem#2468)
  Convert underscores in article slugs properly (forem#2472)
  Update framework defaults to match those in Rails 5.1 (forem#2309)
  Enable random order for specs (forem#2466) [ci skip]
  forem#118 Allow users to embed Medium posts with Liquid Tags (forem#1161)
  Allow API to return top articles (forem#2469)
  ...

# Conflicts:
#	Envfile
#	app/models/user.rb
#	db/schema.rb
@Zhao-Andy
Copy link
Contributor

Resolved by #1161

@jessleenyc
Copy link
Contributor

Keeping this open bc we still need to make some design tweaks before making it available!

@jessleenyc jessleenyc reopened this Apr 23, 2019
@jessleenyc
Copy link
Contributor

Forgot to close this -- its available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

No branches or pull requests

8 participants