Refactor /search/chat_channels endpoint

[atsmith813]

In #13235 we refactored how /search/chat_channels works by essentially removing "search" functionality and turning it into more of a "filter". As noted in the PR:

You'll notice I left everything in the Search namespace (the route, the controller, and the service naming). I originally started removing chat_channels from search all together since this behaves more like a filter than a search.

However, I discovered there are some JS components that are using this endpoint as an "index". I started refactoring everything, but it quickly got out of hand and out of scope for what this PR is intended to address. I also realized it may actually be nice to leave everything in the search namespace so that when we re-do the search for Connect in the future, it's a smoother experience.

With that said, since we have the ChatChannelsController and the ChatChannelMembershipsController each with index actions, I think the right move would be to move those JS components to them so we don't have multiple controllers performing the same actions.

This issue is to essentially update all the JS components on the frontend to use a newly refactored endpoint that lives in a more appropriate spot (i.e. ChatChannelMembershipsController or ChatChannelsController) than the SearchController. Once this issue is complete, the chat_channels action should no longer exist in the SearchController and instead, a new endpoint should be able to take care of any "filtering" and "indexing" being done by the JS components.

[github-actions]

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

[rhymes]

+1 on removing the code out of search and into a dedicated query object / service

[Rafi993]

Hi, if this issue is not worked on I would like to help.

[cmgorton]

Hi, if this issue is not worked on I would like to help.

Thanks Rafi! Just assigned you to it.

[Rafi993]

Sorry I did not look at this issue for a while I will look at this over next week but in the mean time if this is an urgent issue and I am blocking it do feel free to change the owner.

[cmgorton]

I don't believe it is urgent so if you still want to work on it that is totally fine. If not we can remove your assignment. Just let me know what works for you Rafi 😄

[Rafi993]

Thank you @cmgorton. I'll actually un-assign myself now and comeback later to pick up this issue if this still open :)

[twinsfan421]

I can work on this

[cmgorton]

I can work on this

Thank you!

[cmgorton]

Hey @twinsfan421
I was reminded by a teammate that we are putting work on Connect on hold at the moment while we plan out the future of Connect and any work we want done on it. I don't want you to work on this issue only to have us remove the code later on, so I am going to unassign you for now. Please let me know if there are any other issues you would like to work on and thanks again for your willingness to contribute here🙏

[cmgorton]

I am going to close this issue since we are moving to deprecate connect.
Deprecating Connect Chat