Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect render of Saved/Bookmarked button in the reading list #1347

Closed
ghost opened this issue Dec 17, 2018 · 3 comments
Closed

Incorrect render of Saved/Bookmarked button in the reading list #1347

ghost opened this issue Dec 17, 2018 · 3 comments
Labels
bug always open for contribution
Milestone

Comments

@ghost
Copy link

ghost commented Dec 17, 2018

Describe the bug
clicking the "LOAD MORE POSTS" button in the readinglist, the "SAVED" bookmarks button after each article becomes "SAVE" showing as if posts are not bookmarked. See screenshots below

To Reproduce
Steps to reproduce the behavior:

  1. Go to your reading list - here
  2. Now below every post you should see a "SAVED" button indicating post is bookmarked.
  3. Scroll down and click "LOAD MORE POSTS"
  4. Now, below every post you will see a "SAVE" button as if posts are not bookmarked.

Screenshots

  • Normal Reading list:
    annotation

  • When i click "LOAD MORE POSTS" button:
    annotation1

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox(No Extensions)

Additional context
Normal button:

<button class="article-engagement-count bookmark-engage selected">

When the "LOAD MORE POSTS" button is clicked, the class selected class is removed making button:

<button class="article-engagement-count bookmark-engage">
@Zhao-Andy Zhao-Andy added the bug always open for contribution label Dec 17, 2018
@Zhao-Andy
Copy link
Contributor

Hey @imadityang, thanks for the bug report!

@mariocsee
Copy link
Contributor

I think this issue may have been solved by PR #1927, which closed other reading list issues #1395 and #1785. Currently, I can't recreate this on my reading list with Chrome, Firefox, and Safari on MacOS Mojave. Are you still experiencing this, @imadityang?

@ghost
Copy link
Author

ghost commented Mar 20, 2019

@mariocsee Yes it's solved now!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution
Projects
None yet
Development

No branches or pull requests

3 participants