Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jobs_url from SiteConfig and Related Code ✂️ #13470

Closed
5 tasks done
mstruve opened this issue Apr 21, 2021 · 1 comment · Fixed by #13479
Closed
5 tasks done

Remove jobs_url from SiteConfig and Related Code ✂️ #13470

mstruve opened this issue Apr 21, 2021 · 1 comment · Fixed by #13479
Assignees
Labels
internal team only internal tasks only for Forem team members size: estimated XS less than a few days to complete tech: fullstack changes will heavily involve both frontend and backend technologies

Comments

@mstruve
Copy link
Contributor

mstruve commented Apr 21, 2021

Currently, we have code in place that will show a banner with a link to our jobs page if a user searches for "job" or "jobs". This is extremely DEV specific and we have decided that it will not be included in the Forem starter pack so we want to remove it.

Screenshot of the feature in action.
Screen Shot 2021-04-21 at 3 29 35 PM

To do this we need to:

  • remove the jobs_url from SiteConfig
  • remove related code that uses the jobs_url
  • remove code that triggers the banner to show when job or jobs is searched
  • remove anything else related that I forgot ;)
  • communicate change via forem.dev and the admin changelog

Related Stage 0 with Product Sign off: https://github.com/forem/rfcs/issues/201

@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@mstruve mstruve added internal team only internal tasks only for Forem team members size: estimated XS less than a few days to complete tech: fullstack changes will heavily involve both frontend and backend technologies labels Apr 21, 2021
@mstruve mstruve changed the title Remove jobs_url from SiteConfig and Related Code Remove jobs_url from SiteConfig and Related Code ✂️ Apr 22, 2021
@mstruve mstruve added this to Backend Focused in Current Cycle Work Apr 22, 2021
@mstruve mstruve self-assigned this Apr 22, 2021
@mstruve mstruve moved this from Backend Focused to In Progress 🖥 in Current Cycle Work Apr 22, 2021
Current Cycle Work automation moved this from In Progress 🖥 to DONE 🎉 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal team only internal tasks only for Forem team members size: estimated XS less than a few days to complete tech: fullstack changes will heavily involve both frontend and backend technologies
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant