Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook for crayons-tabs redirects off page #13601

Closed
Link2Twenty opened this issue Apr 30, 2021 · 5 comments · Fixed by #14491
Closed

Storybook for crayons-tabs redirects off page #13601

Link2Twenty opened this issue Apr 30, 2021 · 5 comments · Fixed by #14491
Assignees
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. bug smash Approved bugs for the DEV community bug smash bug always open for contribution external contributors welcome contribution is welcome!

Comments

@Link2Twenty
Copy link
Contributor

Describe the bug

Currently the story for tabs doesn't really show what the tabs do. You can see the default state but can't click on a tab.

To Reproduce

  1. Go to storybook
  2. Click on a tab
  3. You are redirected off the page

Expected behavior

Clicking a tab should update which tab is marked as current but should not navigate away.

Screenshots

N/A

Desktop (please complete the following information):

N/A

Smartphone (please complete the following information):

N/A

Additional context

The code is located here
/app/javascript/crayons/navigation/NavigationTabs/stories/navigationTab.html.stories.jsx

I'd probably update the href to # and add some JS to handle the active state.

@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@citizen428 citizen428 added area: design Use for all tasks related to UX, UI, visual, or interaction design. Crayons bug always open for contribution labels May 6, 2021
@aitchiss
Copy link
Contributor

aitchiss commented Jun 3, 2021

I'd probably update the href to # and add some JS to handle the active state.

I think that will be a good solution 🙂

Our "Tabs" component is more of a group of navigation links than a classic "tab panel", so you're right, the links need to go somewhere. I agree, using "#" as the href would allow us to stay on the same page and we can track the current tab with some JS in the story itself.

@aitchiss aitchiss added the external contributors welcome contribution is welcome! label Jun 3, 2021
@cmgorton cmgorton added the bug smash Approved bugs for the DEV community bug smash label Aug 9, 2021
@payapula
Copy link
Contributor

Hi @cmgorton

I would like to pick this up 😄

@rhymes
Copy link
Contributor

rhymes commented Aug 11, 2021

@payapula I've assigned it to you, thanks!

payapula pushed a commit to payapula/forem that referenced this issue Aug 12, 2021
payapula added a commit to payapula/forem that referenced this issue Aug 12, 2021
@payapula
Copy link
Contributor

This should be fixed by #14491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. bug smash Approved bugs for the DEV community bug smash bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
6 participants