New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook for crayons-tabs redirects off page
#13601
Comments
|
Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you. Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev. To our amazing contributors: issues labeled To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up. For full info on how to contribute, please check out our contributors guide. |
I think that will be a good solution 🙂 Our "Tabs" component is more of a group of navigation links than a classic "tab panel", so you're right, the links need to go somewhere. I agree, using "#" as the href would allow us to stay on the same page and we can track the current tab with some JS in the story itself. |
|
Hi @cmgorton I would like to pick this up 😄 |
|
@payapula I've assigned it to you, thanks! |
|
This should be fixed by #14491 |
Describe the bug
Currently the story for tabs doesn't really show what the tabs do. You can see the default state but can't click on a tab.
To Reproduce
Expected behavior
Clicking a tab should update which tab is marked as current but should not navigate away.
Screenshots
N/A
Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
The code is located here
/app/javascript/crayons/navigation/NavigationTabs/stories/navigationTab.html.stories.jsx
I'd probably update the
hrefto#and add some JS to handle the active state.The text was updated successfully, but these errors were encountered: