Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra space from readable_publish_date #13612

Closed
hadiidbouk opened this issue May 2, 2021 · 5 comments · Fixed by #13660
Closed

Remove extra space from readable_publish_date #13612

hadiidbouk opened this issue May 2, 2021 · 5 comments · Fixed by #13660
Assignees
Labels
bug smash Approved bugs for the DEV community bug smash bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.

Comments

@hadiidbouk
Copy link

I am using the GET latest articles endpoint in my project.

The readable_publish_date property added an extra space between the day and the month, this could be fixed on the front end, but if it's a readable publish date why not be better readable 😅

Screen Shot 2021-05-02 at 6 42 01 PM

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@citizen428
Copy link
Contributor

Thanks for the issue. The problem here is that Ruby pads %e with whitespace. This can be prevented by changing the format specifier to %-e:

Date.today.strftime("%b %e")
#=> "May  5"
Date.today.strftime("%b %-e")
#=> "May 5"

@citizen428 citizen428 added bug always open for contribution good first issue good first issues for anyone new to programming and new to the project. external contributors welcome contribution is welcome! bug smash Approved bugs for the DEV community bug smash labels May 5, 2021
@Arun-kc
Copy link
Contributor

Arun-kc commented May 5, 2021

Can I help? @citizen428

@rhymes
Copy link
Contributor

rhymes commented May 5, 2021

@Arun-kc I've assigned this to you! Thank you!

@Arun-kc
Copy link
Contributor

Arun-kc commented May 5, 2021

@Arun-kc I've assigned this to you! Thank you!

Thank you! @rhymes 😇. This is my first time doing a major PR. Hope what I did is correct 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug smash Approved bugs for the DEV community bug smash bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants