Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Follow" text missing from Podcast Liquid tag display. #13667

Closed
cmgorton opened this issue May 5, 2021 · 8 comments · Fixed by #14790
Closed

"Follow" text missing from Podcast Liquid tag display. #13667

cmgorton opened this issue May 5, 2021 · 8 comments · Fixed by #14790
Assignees
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@cmgorton
Copy link
Contributor

cmgorton commented May 5, 2021

Describe the bug

When using the podcast liquid tag in an article the button that should have "Follow" no longer displays the text. I tested this with several podcasts and none of them display the "Follow" text.

To Reproduce

  1. Navigate to the editor to create a new post.
  2. Use the podcast liquid tag to render any of the podcasts on DEV {% podcast url-for-episode-here %}
  3. click preview to preview the liquid tag
  4. Scroll down to the rendered podcast liquid tag; it will be displayed with an empty button that should contain "Follow"

Expected behavior
Follow text inside of the empty button

Screenshots
Screen Shot 2021-05-05 at 9 30 24 AM
Screen Shot 2021-05-05 at 9 30 57 AM
Screen Shot 2021-05-05 at 9 31 35 AM

Here you can see the text is not rendered at all in the HTML
Screen Shot 2021-05-05 at 9 33 59 AM

@cmgorton cmgorton added bug always open for contribution bug smash Approved bugs for the DEV community bug smash labels May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@oryanmoshe
Copy link

oryanmoshe commented May 5, 2021

I'd like to take this one as well
@cmgorton

@cmgorton
Copy link
Contributor Author

cmgorton commented May 5, 2021

Great! Just assigned it to you. Thanks for the help😄

@snyntakk
Copy link

snyntakk commented May 8, 2021

i would like to take this one

@meg-gutshall
Copy link
Contributor

Looks like line 39 in your views/podcast_episodes/show.html.erb file is a good place to start!

@erenlerfirat
Copy link

erenlerfirat commented May 11, 2021

Hello , do Bug smash have discord channel ? @cmgorton

@cmgorton
Copy link
Contributor Author

Hello , do Bug smash have discord channel ? @cmgorton

Hey! No we do not have a discord channel. If you have any questions you can post on the Bug Smash event announcement or find me here on GitHub :)

A discord or some other channel of communication isn't a bad idea and something I will keep in mind for future bug smash events.

@erenlerfirat
Copy link

erenlerfirat commented May 11, 2021 via email

@cmgorton cmgorton removed the bug smash Approved bugs for the DEV community bug smash label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
5 participants