Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor v2 upload image overlay breaks layout with small screen on upload #1389

Closed
rhymes opened this issue Dec 21, 2018 · 9 comments
Closed
Assignees
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.

Comments

@rhymes
Copy link
Contributor

rhymes commented Dec 21, 2018

Describe the bug

Opening the upload image overlay in the v2 editor with a 13" inch screen and trying to upload an image, breaks the layout.

The content (the section direct url) also disappears below the bottom toolbar

To Reproduce
Steps to reproduce the behavior:

  1. Resize the browser window (my screen is 13" with 1280x800 resolution)
  2. Go https://dev.to/new with the v2 editor
  3. Click on "browse" and select an image
  4. See error

Expected behavior

The overlay should enlarge with the new content added

Screenshots

noscroll

Desktop (please complete the following information):

  • OS: macOS 10.14.2
  • Browser: Firefox
  • Version: 64
@maestromac maestromac added the bug always open for contribution label Dec 21, 2018
@maestromac
Copy link
Member

Thank you for reporting this @rhymes !

@jessleenyc jessleenyc added the external contributors welcome contribution is welcome! label Jan 8, 2019
@stale
Copy link

stale bot commented Apr 8, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Apr 8, 2019
@rhymes
Copy link
Contributor Author

rhymes commented Apr 8, 2019

unstale my heart

@stale stale bot removed the stale label Apr 8, 2019
@jessleenyc jessleenyc added area: publishing experience issues related to an authors experience publishing. Tags, series, etc. good first issue good first issues for anyone new to programming and new to the project. tech: html/css labels Aug 1, 2019
@dev-encourt dev-encourt self-assigned this Oct 18, 2019
@cyberShaw
Copy link

Can I work on this issue?

@rhymes
Copy link
Contributor Author

rhymes commented May 12, 2020

Hi @cyberShaw, sure! I'm going to assign it to you :-)

@cyberShaw
Copy link

Is there any Slack or Discord for Dev.To for communication and asking for help? I'm a little new to open source :D

@rhymes rhymes removed the future label Jul 1, 2020
@ludwiczakpawel
Copy link
Contributor

Fixed.

@rhymes
Copy link
Contributor Author

rhymes commented Sep 9, 2020

@ludwiczakpawel so it can be closed?

@ludwiczakpawel
Copy link
Contributor

Yes sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

No branches or pull requests

6 participants