Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter user posts in profile page by tag #1396

Closed
rhymes opened this issue Dec 22, 2018 · 11 comments
Closed

Filter user posts in profile page by tag #1396

rhymes opened this issue Dec 22, 2018 · 11 comments
Labels
area: profile user's profile, settings, dashboard area: search/indexing search results and indexing

Comments

@rhymes
Copy link
Contributor

rhymes commented Dec 22, 2018

Is your feature request related to a problem? Please describe.

Some users have many posts on their profile pages, it would be nice to be able to filter those by tag.

Describe the solution you'd like

I envision this feature split in two sub features:

  • a "tag cloud" in a box on the right side of the profile page
  • when a tag is clicked the profile page reloads/refetches ony with the posts belonging to such tag

Not sure about the UX of going back to the unfiltered list

@pkfrank
Copy link
Contributor

pkfrank commented Dec 23, 2018

Added the feature request label, and look forward to discussing with the team. Also not sure about the UX here, but this definitely makes sense — especially for authors who are particularly prolific.

@benhalpern
Copy link
Contributor

I agree with this in every way except I'm unsure about the "tag cloud" part. But I wouldn't mind having that built as an MVP and then we adjust from there if needed.

@benhalpern benhalpern added the external contributors welcome contribution is welcome! label Dec 31, 2018
@ilonacodes
Copy link

@pkfrank @benhalpern
I have played around your UI/UX and would like to suggest the following option:

screen shot 2019-01-13 at 21 21 48

It seems like it solves the problem with the "show all" filter option.

What do you think about the solution?

@benhalpern
Copy link
Contributor

@ilonacodes Yeah that makes a lot of sense!

That's an area where I feel like we could adjust some of the styling in both places, but it definitely makes sense to use the same UI in both places.

I think ultimately @aspittel should have a good say in this, but it's starting to make sense to me at this point.

In terms of how we use the left and right sidebars, it might make more sense on the left sidebar. And possibly start collapsed and be expandable.

@ilonacodes
Copy link

@aspittel @benhalpern

Thank you for the feedback!

I'd like to implement this feature. Does it make sense to start it now or should I wait?

@aspittel
Copy link
Contributor

Yeah, I definitely think it looks consistent with the rest of the site. I also agree with @ben that maybe in the future we can spruce both up, but if we reuse the CSS that shouldn't be difficult to do. For profiles that are more built out, what order would this go in? Before or after badges and the other features?

@jessleenyc jessleenyc added the area: profile user's profile, settings, dashboard label Mar 26, 2019
@jessleenyc
Copy link
Contributor

Would this also make sense as an additional search box? Or if we supported searching with specific parameters? user: aspittel tag: ruby?

@cmgorton
Copy link
Contributor

This looks like the type of feature that would be both useful on DEV and Forem in general. I am going to add this to the feature backlog project board.

@cmgorton cmgorton added this to Backlog in Feature backlog Nov 18, 2020
@cmgorton
Copy link
Contributor

@rhymes do you think this one should be labelled with a potential RFC label?
It has been around for awhile with little traction so wondering if we should either highlight this or go a head and close it. Thoughts?

@rhymes
Copy link
Contributor Author

rhymes commented Jan 19, 2021

Mmm I don't think it's RFC material, unless the product team thinks otherwise or the design team is actually planning on revamping the profile page so that a change like this might be done in the context of a larger redesign.

@cmgorton cmgorton added potential RFC and removed external contributors welcome contribution is welcome! labels Feb 2, 2021
@cmgorton cmgorton removed this from Backlog in Feature backlog Feb 23, 2021
@cmgorton
Copy link
Contributor

This issue has gone stale. With the backlog of feature requests we currently have and are prioritizing I am going to close this issue. Maybe we can revisit it in the future. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: profile user's profile, settings, dashboard area: search/indexing search results and indexing
Projects
None yet
Development

No branches or pull requests

8 participants