Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the admin confirmation email template #14376

Closed
nickytonline opened this issue Jul 28, 2021 · 3 comments
Closed

Create the admin confirmation email template #14376

nickytonline opened this issue Jul 28, 2021 · 3 comments
Assignees
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. internal team only internal tasks only for Forem team members

Comments

@nickytonline
Copy link
Contributor

nickytonline commented Jul 28, 2021

Descripton

As part of the admin onboarding, an admin onboarding email template needs to be created. It's possible that it's currently the same email template for non-admin users.

Related Issues & Documents

Investigation (from Slack convos)

@nickytonline: I've never worked with emails in the project, but I dug a bit, and it looks like account_ownership_verification_email.html.erb and account_ownership_verification_email.txt.erb is what's used for anyone that onboards? Confirm their email, then start onboarding? Is that correct? I wasn't able to find anything admin specific in terms of onboarding, which is very possiblw as @Ridhwana wasn't sure if it was a separate template or not.

@Zhao-Andy: account_ownership_verification_email is actually for a one-off case when we have a user claiming to be someone, and we send this out via /admin/users to verify they own the account (and associated email address) in question.

For confirming emails in general (ie. changing emails, first signing up via email) this happens through the Devise gem, and because we don't have any custom HTML or styling for that email, we use the default email.html.erb and email.txt.erb that's done by the gem -- and therefore, no file for it within app/views/mailers.

If you're trying to make a brand new email for admins to welcome them with an onboarding email, I would look into the classes in app/mailers and follow some code patterns there. IMO, Rails' docs are pretty good at explaining how the email backend works in general: https://guides.rubyonrails.org/action_mailer_basics.html

@nickytonline nickytonline self-assigned this Jul 28, 2021
@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@rhymes rhymes added area: design Use for all tasks related to UX, UI, visual, or interaction design. area: email labels Jul 28, 2021
@citizen428
Copy link
Contributor

@nickytonline "actual confirmation email"? Do you maybe mean "admin confirmation email"? Also, should we add a "form team" label here, it doesn't seem like this is an issue meant for external contributors.

@nickytonline
Copy link
Contributor Author

@nickytonline "actual confirmation email"? Do you maybe mean "admin confirmation email"? Also, should we add a "form team" label here, it doesn't seem like this is an issue meant for external contributors.

Ahh, yeah, I generated this issue from a card on our board. I'll make the changes you mentioned.

@nickytonline nickytonline added this to Frontend Focused in Current Cycle Work Jul 29, 2021
@nickytonline nickytonline added the internal team only internal tasks only for Forem team members label Jul 29, 2021
@nickytonline nickytonline changed the title Update the copy and style of the actual confirmation email Update the copy and style of the admin confirmation email Jul 29, 2021
@nickytonline nickytonline changed the title Update the copy and style of the admin confirmation email Create the admin confirmation email template Aug 17, 2021
@Ridhwana Ridhwana closed this as completed Nov 2, 2021
Current Cycle Work automation moved this from Frontend Focused to DONE 🎉 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. internal team only internal tasks only for Forem team members
Projects
No open projects
Development

No branches or pull requests

4 participants