New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runkit: can't place HTML tags in embed #14470
Comments
Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you. Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev. To our amazing contributors: issues labeled To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up. For full info on how to contribute, please check out our contributors guide. |
Even weirder: If you place a runkit embed with a {% runkit %}
// Some other code
foo();
bar();
const element = '<h1>';
{% endrunkit %}
{% runkit %}
const element = '<br>';
{% endrunkit %} Then the first block doesn't disappear anymore |
I'll take it |
@squarebat all yours, thanks! |
unassigned myself since I won't be able to work on this for two weeks. Seeing that it is a part of bug smash, I want to leave it open to other contributors. Happy debugging! |
This is part of how Markdown works, see https://daringfireball.net/projects/markdown/syntax#html. |
The problem is around runkit_tag.rb:76
The second line of code strips all tags. The first idea would to fix this line, but the problem is in earlier code
Would create the final output in the runkit_tag.rb:76 as follows
Now we do not know which tags to remove and which to keep. Proposed solutionAdd codeticks inside between runkit and endrunkit so that they are processed as code. A simplified solution would look like this
This would force the processing of Redcarpet to treat it as block of code in html_rouge.rb:11 |
Describe the bug
If you try to put any HTML tags in embeds:
const element = '<br>';
We get some really weird behavior. If you place a
<br>
(or any closing or self-closing tags), it just disappears:If you place an
<h1>
, or a<hr>
:The whole thing disappears:
To Reproduce
Expected behavior
The tags are shown properly.
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
NA
The text was updated successfully, but these errors were encountered: