Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-related Liquid tags improperly render text sometimes #1459

Closed
Zhao-Andy opened this issue Jan 3, 2019 · 2 comments
Closed

DEV-related Liquid tags improperly render text sometimes #1459

Zhao-Andy opened this issue Jan 3, 2019 · 2 comments
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution external contributors welcome contribution is welcome!

Comments

@Zhao-Andy
Copy link
Contributor

Bug Report

user, tag, and link Liquid tags, when used in certain contexts, do not render text properly.

For example, with these two Markdown examples:

Isn't {% tag discuss %} about that?
# or 
Isn't {% tag discuss %}
about that?

Will render something like:

image

The issue is that the about that? is not being wrapped with a <p> tag, but has a line break <br> immediately after the Liquid tag <div>.

I tested this with the CodePen tag and that worked out okay.

A temporary fix is to add an additional line after using the DEV-related Liquid tag:

Isn't {% tag discuss %}

about that?
@Zhao-Andy Zhao-Andy added the bug always open for contribution label Jan 3, 2019
@jessleenyc jessleenyc added the external contributors welcome contribution is welcome! label Jan 8, 2019
@mariocsee
Copy link
Contributor

Couldn't recreate issue in development and there's no more line break immediately after the Liquid Tag in development and production

@jessleenyc jessleenyc added the area: publishing experience issues related to an authors experience publishing. Tags, series, etc. label Mar 26, 2019
@jessleenyc
Copy link
Contributor

Going to close this since we couldn't recreate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

3 participants