Tag page - All page content should be contained within landmarks

[aitchiss]

Describe the bug

For accessibility purposes, all content should be contained within landmark regions. On the tag page, e.g. https://dev.to/t/devops, the content in the left and right sidebars (desktop view) are not within any landmark:

In this case, the content could reasonably exist within <aside> elements ( "complementary" landmark), since they support the main content, but are not essential to it, and make sense when separated from the main content.

NB: This refers to the large-screen 'desktop' view pictured above only. On smaller screens, the content is triggered as a pop-up menu. For the purposes of this issue we do not wish to change any of the markup for the pop-up menu.

To Reproduce

• Visit a tag's page
• In devtools, use the axe extension to check the page
• Notice the error "All page content should be contained by landmarks"

Expected behavior

• The error should not appear in an axe report
• When I navigate by landmarks using a screen reader, I should be able to select a landmark to navigate to this sidebar content

Additional context

There is a different class of accessibility issues associated with the smaller screen 'menu popup' view for this content. It will be captured in a separate issue, and needn't affect the fix here.

[github-actions]

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

[metamoni]

Hey, @aitchiss, I'd like to work on this one if that's OK :)

[aitchiss]

Yeeha! That's awesome - I've assigned it to you now @metamoni 😄

[rhymes]

Closed by #14899