Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expand/collapse ticks into comment cards #1518

Closed
Arteneko opened this issue Jan 11, 2019 · 1 comment
Closed

Move expand/collapse ticks into comment cards #1518

Arteneko opened this issue Jan 11, 2019 · 1 comment

Comments

@Arteneko
Copy link

Is your feature request related to a problem? Please describe.

When I first saw the expand/collapse ticks, I didn't understand the original purpose of them.

After hovering them, and seeing that it was not simply a bug in the website, but an actual action, I understood its purpose.

I think that the tick's not explicit, and its positioning wrong: it changes the comment card's state, I'd expect to find it in the card.

Additional context

For nested comments, maybe the parent card could contain child cards in design?

Finally, here's a screenshot of an example of ticks and nested comments:

@cmgorton
Copy link
Contributor

Hey @Arteneko !

Thank you so much for opening this issue/discussion! Our design team is in the process of changing the UI for the comment cards and this will no longer be an issue with the new design.
I am going to go a head and close this issue.

We couldn't do what we do without awesome community members like yourself, thank you so much for being a part of our awesome Forem community 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants