Tag liquid tag overflowing comment box in notifications

[jessleenyc]

Describe the bug
Styling of the tag liquid tag is getting cut off / not minimizing properly.

Screenshots

[ghost]

Can I take this up for fix? @jessleenyc

[Zhao-Andy]

@grv19 go for it! Let us know if you have questions.

[ghost]

@Zhao-Andy Can you help reproduce this? I'm not able to reproduce.

[jessleenyc]

Not sure if this is still an issue but to try reproducing you'll want to:

• Create two users (yours and another)
• Create a post under your account
• Make sure you're running delayed jobs: rake jobs:work
• Have the other account leave a comment with the tag liquid tag

As long as jobs are running you should be able to see a notification come in.

[coolbrg]

I am also not able to reproduce it.

I exactly followed the steps mentioned by @jessleenyc #1520 (comment) .

and added comment as

# contributorwanted

{% user jess %} some text

I am still able to reproduce it.

I will be working on it too :)

[coolbrg]

I found that the style in this line
https://github.com/thepracticaldev/dev.to/blob/c09a5c70f1d9989ec49b162bf59a3c8f594bd03b/app/views/tags/_liquid.html.erb#L1

need to be appended with width: auto.

However, on updating the file and reloading the server, it doesn't reflect the changes.

Is there anything I am missing here?

[maestromac]

Hello @coolbrg , each liquid tag are generated and saved as part of body_markdown. You'll need to create a new article and follow Jess's direction again to see the change.

[coolbrg]

Thanks @maestromac for the pointers. Appreciated.

[luchiago]

HI, does this problem still need help?

[coolbrg]

HI, does this problem still need help?

@luchiago Yes, please go ahead as I am not getting much time to dig into it.

This is the last point where I could reach #1520 (comment)

[luchiago]

@coolbrg but could you reproduce the bug?

[coolbrg]

@coolbrg but could you reproduce the bug?

@luchiago Yes

[luchiago]

@coolbrg how can I use the users from seeds to make manual tests? Like, have my Github account logged and after that login with a user from database?

[maestromac]

@luchiago what would you like to accomplish? You could control seed db users via rails consoler to make. Commands like

that_user.follow(me)
me.follow(that_user)

should get you started with notifications. Be sure you have the background jobs running too bin/rails jobs:work

[luchiago]

@maestromac Yeah it's something like that I was searching for to reproduce the bug. Thank you.

[AlbertoPdRF]

Hello @coolbrg , each liquid tag are generated and saved as part of body_markdown. You'll need to create a new article and follow Jess's direction again to see the change.

I'm working on this issue, and even after doing this I'm not able to see the change. Any clue of what may be going wrong?

EDIT: it was a problem on my side, I'm seeing my changes applied now :)

[coolbrg]

EDIT: it was a problem on my side, I'm seeing my changes applied now :)

Glad to hear and see it fixed 👍