Comments overlapping in Edge

[kingdamian42]

Describe the bug
When using Edge, some comments render as overlapping eachother

To Reproduce
Steps to reproduce the behavior:

1. Go to https://dev.to/ilonacodes/frontend-developers-do-you-want-to-transition-to-fullstack-why-44b9 in Edge
2. Scroll down to the first child comments under "Xander"'s comment.
3. See error

Expected behavior
The comments should not overlap while using Edge.

Screenshots
Example of issue: https://imgur.com/a/IW3sbEG

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Edge
• Version: Microsoft Edge 42.17134.1.0

[Zhao-Andy]

Thanks for the report. This is most likely because we have HTML toggles that collapse and expand the comments, but it's not supported by Edge yet.

https://caniuse.com/#search=details

[Link2Twenty]

@Zhao-Andy @benhalpern
It looks like it's caused by

.comments-container details details .comment-deep-1, .comments-container details details .comment-deep-2 {
   margin-top: -123px;
}

Which I guess is there for the details stuff?

---

It's the sort of thing we can hack away but is that the road we want to go down?

/* will only work in edge and IE */
@supports (-ms-ime-align:auto) {
  .comments-container details details .comment-deep-1, .comments-container details details .comment-deep-2 {
    margin-top: 0px;
  }
}

[benhalpern]

@Link2Twenty I think that hack is okay in this case.

We knew the <details> element wasn't going to be supported by Edge, but went ahead with the idea that it was okay because it generally looked like it never existed overlooked this part when making the additional change of putting the toggle button next to sub-comments.

So it seems like a sensible patch that doesn't add unnecessary debt elsewhere.

[stale]

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

[Zhao-Andy]

Still an issue. @Link2Twenty's suggestion should be a good starting place if anyone wants to work on this.

[maestromac]

Resolved with #3553