Changing an organization's image should invalidate the associated articles cached organization

[jeremyf]

Current behavior:

Given an article A that is associated with organization B.
When I update the organization B's image.
Then article A's organization image does not reflect the new image for B.

Expected behavior:

Given an article A that is associated with organization B.
When I update the organization B's image.
Then article A's organization image reflects the new image for B.

In the below image, I would expect that if I changed the DEV image to something else that the DEV icon behind Gracie would reflect that change.

The following code highlights how we cache the article's organization:

forem/app/views/articles/_single_story.html.erb

Lines 26 to 30 in f5ae290

	<% if story.cached_organization && !@organization_article_index %>
	<a class="crayons-logo crayons-logo--l" href="/<%= story.cached_organization.slug %>">
	<img alt="<%= story.cached_organization.name %> logo" src="<%= story.cached_organization.profile_image_90 %>" class="crayons-logo__image" loading="lazy" />
	</a>
	<% end %>

The current work around is that you would need to edit all articles to recalculate the cache.

[github-actions]

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

[jeremyf]

In the Organization model we have the following:

forem/app/models/organization.rb

Lines 144 to 154 in 0fc1a40

	def update_articles
	return unless saved_change_to_slug || saved_change_to_name || saved_change_to_profile_image
	articles.update(cached_organization: Articles::CachedEntity.from_object(self))
	end
	def update_articles_cached_organization
	return unless saved_change_to_attribute?(:name)
	articles.update(cached_organization: Articles::CachedEntity.from_object(self))
	end

Which are called in these two spots:

forem/app/models/organization.rb

Line 18 in 0fc1a40

before_save :update_articles

forem/app/models/organization.rb

Line 26 in 0fc1a40

after_update_commit :update_articles_cached_organization

And as part of "updating" the articles, we call the following:

forem/app/models/article.rb

Line 152 in 0fc1a40

before_save :update_cached_user

Which has the method body:

forem/app/models/article.rb

Lines 828 to 831 in 0fc1a40

	def update_cached_user
	self.cached_organization = organization ? Articles::CachedEntity.from_object(organization) : nil
	self.cached_user = user ? Articles::CachedEntity.from_object(user) : nil
	end

So we're attempting to update an article's cached organization three different times. And it is possible that the Article. update_cached_user is using a cached value for organization.

We definitely don't need to update these things so many times.