Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should dropdown be used for editor version selection? #1775

Closed
aligoren opened this issue Feb 11, 2019 · 3 comments
Closed

Should dropdown be used for editor version selection? #1775

aligoren opened this issue Feb 11, 2019 · 3 comments
Labels
external contributors welcome contribution is welcome!

Comments

@aligoren
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In my opinion, It's annoying always writing editor version. I'm not sure but if there is a version number 99, the user will have to write v99.

Instead of this, the select tag can be useful.

Describe the solution you'd like

I think we can change the input element with a select element like below:

<label for="user_editor_version">Editor version: v1 or v2</label>
<select name="user[editor_version]" id="user_editor_version">
    <option value="v1">v1</option>
    <option value="v2">v2</option>
</select>

And css will be like that

width: 650px;
max-width: calc(100% - 30px);
padding: 12px;
font-size: 19px;
border: 1px solid #dee6e9;
border-radius: 3px;

Describe alternatives you've considered

The other alternative is Radio Button if there are two versions.

Additional context

I changed input with the select tag using Chrome's Developer Tool.

It looks like below;

image

In this example, I changed my editor version using the select tag.

@jessleenyc
Copy link
Contributor

Yeah, this makes sense to me. I haven't brought it up in meetings but I've been meaning to submit a PR that makes the change. If anyone else wants to, please go for it.

@venarius
Copy link

@benhalpern I guess this can be closed.

@maestromac
Copy link
Member

Resolved with #2107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

4 participants