Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer visually overlaps Left Hand Nav Card #1794

Closed
TerabyteTiger opened this issue Feb 12, 2019 · 9 comments
Closed

Footer visually overlaps Left Hand Nav Card #1794

TerabyteTiger opened this issue Feb 12, 2019 · 9 comments
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@TerabyteTiger
Copy link
Contributor

Describe the bug
In a Chrome window sized 1305x842, I scrolled to the bottom of the "My Reading List" and the Footer overlapped the Left Hand Card.
visual overlap showing

To Reproduce
Steps to reproduce the behavior:
0. (Resize window to ~ 1305 x 842)

  1. Go to "My Reading List"
  2. Scroll down to the bottom of the page (As far down as possible)
  3. See overlap

Expected behavior
I'm not sure what the bet way to handle this is, but possibly by shrinking the width of the footer card to match the width of the center column.

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version 72.0.3626.96
@Link2Twenty
Copy link
Contributor

Looks as though if the height is below 880px and the width is above 950px this issue will arise.

@aspittel aspittel added bug always open for contribution external contributors welcome contribution is welcome! labels Feb 14, 2019
@aspittel aspittel removed the external contributors welcome contribution is welcome! label Feb 14, 2019
@aspittel
Copy link
Contributor

Thanks for reporting this @12vanblart, and thank you @Link2Twenty for looking into it more! Will look into this.

@willamesoares
Copy link
Contributor

Hey @aspittel, is this currently being worked on by someone? If not, let me know and I can take a look at it this week, thanks ;)

@mariocsee
Copy link
Contributor

@willamesoares are you currently working on this? If not, I can hop on it soon

@willamesoares
Copy link
Contributor

@mariocsee I was hoping that someone would let me know that this could be worked on since I don't know if there's someone already on it. I think since I didn't get any answer I'll just go ahead and fix this ;)

@mariocsee
Copy link
Contributor

@willamesoares It doesn't seem like anyone is working on this, especially since no PR has referenced this issue. Thanks Will!

@willamesoares
Copy link
Contributor

Hey, @mariocsee I looked into this and realized there are a few ways of solving it but I'm not sure which layout would be better since this needs more discussion. I was thinking about making the footer the same width as the posts list container for screens sizes that show the overlap and keep the current behavior for other sizes.

Would you be willing to take a shot at this one and see if you can come up with an alternative for what I proposed and then we could investigate which way would be better from a UX/UI standpoint?

@mariocsee
Copy link
Contributor

@willamesoares Looking at how articles pages have the footer width match with the article content to prevent overlap with the cards on the right side, I think you've good idea of how to go about this issue to prevent the overlap with the cards on the left. Something to potentially check for is how the footer behaves in other DEV pages since it's used all throughout.

Screen Shot 2019-03-15 at 11 02 06

@maestromac
Copy link
Member

Resolved with #2166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

6 participants