New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Notification initializer to Pack tag #18998
Comments
Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you. Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev. To our amazing contributors: issues labeled To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up. For full info on how to contribute, please check out our contributors guide. |
Correct me if I'm wrong but from my understanding these pack files are not tested. If they aren't, would we want to add some tests for them as we migrate them? What do we think the effort vs reward for these would be? cc @mirie @lboogie04 |
Also curious to get @maestromac's perspective on this as he works on increasing test coverage. |
@lboogie04 / @maestromac what are your thoughts on this? I added some buffer to include testing in the estimate |
Yes, I think this is a ripe opportunity to also add test along with the migration and I apologize for the additional work this may put on @lboogie04 |
@Ridhwana Most definitely! |
In an effort to migrate away from asset pipeline, the current initializers need to be migrated to pack tags via Webpacker and initialized in the perspective view/page.
The
initNotifications()
should be migrated to a pack tag and added to the perspective views in which this code should be initialized.The text was updated successfully, but these errors were encountered: