Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image uploader button on comment forms jumps up once a file is selected #3085

Closed
nickytonline opened this issue Jun 9, 2019 · 3 comments
Closed
Assignees
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@nickytonline
Copy link
Contributor

Describe the bug

The UI moves or covers other UI (in the case of mobile) when an image is selected to be added to a comment.

To Reproduce

  1. Go to any post and click on the image upload button of a comment.
  2. Select a file for upload.
  3. The file gets uploaded.
  4. The text input that contains the URL of the newly uploaded image appears causing the image upload button to move up (desktop) or covers other UI (mobile).

Expected behavior

The UI should not shift or cover other UI.

Screenshots

bug_image_upload

mobile_image_upload_error

Desktop (please complete the following information):

  • OS: macOS 10.14.5
  • Browser: FireFox, Chrome, Safari
  • Version: latest

Smartphone (please complete the following information):

  • Device: iPhone 6 SE
  • OS: iOS
  • Browser: Brave
  • Version: not sure

Additional context

@nickytonline
Copy link
Contributor Author

I have a PR coming up later today tomorrow for this that fixes the desktop issue, but I still need to look into the mobile issue. The refactor in #3082 came about because of this issue.

@nickytonline
Copy link
Contributor Author

Although it looks like an easy fix, it was a little more complicated. A lot ofthe comment form had elements using position: absolute with a lot of calc(...) in the CSS. I opted to go for Flexbox, that ends up reducing the amount of CSS and makes it easier to make changes to the form.

@maestromac
Copy link
Member

Resolved with #3086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

3 participants